From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Dec 2014 16:18:15 GMT
Subject: Re: [PATCH v6 1/1] http: Add Accept-Language header if possible
Message-ID: <xmqqegri1lbs.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cQZG3gWEw8_HHHvP6EDLKkf-nMZLwkE4OF9hwNX72wgXw@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> Just a few comments and observations below. Alone, they are not
> necessarily worth a re-roll, but if you happen to re-roll for some
> other reason, perhaps take them into consideration.

I actually think everything you said in this review makes sense and
will make the resulting code a lot better (especially the part on
the parsing loop).

Thanks, as usual, for a careful reading.