Re: [PATCH v2] gitweb: apply fallback encoding before highlight
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 4, 2016, 19:34 UTC
- Message-ID
- <xmqqeg9hhb1e.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160504083449.GA46041@skmba.local>
Shin Kojima <shin@kojima.org> writes:
> I can say this patch, to consider $fallback_encoding while > highlighting, is fairly rational. But I also feel this is too much > just for specific outdated character encodings, it is completely > useless for the most part of gitweb users in the world.
Oh, don't get me wrong. I do think what the patch does is very sensible and have no intention of rejecting it.
Unless somebody finds a new bug in it, but in that case, we won't be rejecting it but would be improving on it.
As I said, the question was "Just out of curiosity", since it's been so long since I was in any part of software work done in Japan.