Re: [PATCH v2] gitweb: apply fallback encoding before highlight

From: Shin Kojima <shin@kojima.org>
Date: May 4, 2016, 08:34 UTC
Message-ID: <20160504083449.GA46041@skmba.local>
In-Reply-To: <xmqq7ffbng8p.fsf@gitster.mtv.corp.google.com>

On Tue, May 03, 2016 at 11:33:42AM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> Shin Kojima <shin@kojima.org> writes:
> 
> > Some multi-byte character encodings (such as Shift_JIS and GBK) have
> > characters whose final bytes is an ASCII '\' (0x5c), and they
> > will be displayed as funny-characters even if $fallback_encoding is
> > correct.
> 
> Just out of curiosity, do people still use Shift_JIS aka MS-Kanji?
> It feels so last-decade, if not last-century ;-)

Yes, they do. There are still tons of code from 90's lying around.

For migrating our codebase from cp932 (Windows31J/MS-Kanji), I keep failing to persuade my boss saying it has no incentives to do so.

I can say this patch, to consider $fallback_encoding while highlighting, is fairly rational. But I also feel this is too much just for specific outdated character encodings, it is completely useless for the most part of gitweb users in the world.

I would rather prefer to generate feedback from you all to convince our management if this patch is not acceptable.