git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v1] git-p4: fix git-p4.pathEncoding for removed files

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 22, 2016, 21:23 UTC
Message-ID
<xmqqeg0zfyjx.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CAE5ih7-=bD_ZoL5pFYfD2Qvy-XE24V_cgge0XoAvuoTK02EDfg@mail.gmail.com>
Luke Diamand <luke@diamand.org> writes:
Show 12 quoted lines
> The change puts the logic into stripRepoPath() instead, which is
> indeed called from both of those functions (good), but also from
> splitFilesIntoBranches(), but only if self.useClientSpec is set. That
> function only gets used if we're doing the automatic branch detection
> logic, so it's possible that this code might now be broken and we
> wouldn't know.
>
> Lars, what do you think? Other than the above, the change looks good,
> so it may all be fine.
>
> (As an aside, this is the heart of the code that's going to need some
> careful rework if/when we ever move to Python3).
Thanks.  

I'll merge this as-is to 'next', expecting that further refinement can be done incrementally.

Previous: Luke DiamandNext: Lars Schneider
Message 4 of 8 in “git-p4: fix git-p4.pathEncoding for removed files”
  1. git-p4: fix git-p4.pathEncoding for removed fileslarsxschneider@gmail.com, Dec 18, 2016
  2. Junio C HamanoDec 19, 2016
  3. Luke DiamandDec 20, 2016
  4. Junio C HamanoDec 22, 2016
  5. git-p4: fix git-p4.pathEncoding for removed filesLars Schneider, Feb 9, 2017
  6. Junio C HamanoFeb 9, 2017
  7. Luke DiamandFeb 10, 2017
  8. Junio C HamanoFeb 10, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.