Re: [PATCH v2] git-p4: fix git-p4.pathEncoding for removed files

From: Luke Diamand <luke@diamand.org>
Date: Feb 10, 2017, 22:05 UTC
Message-ID: <CAE5ih78xRAOFb+MC53qzNJyZ_d7j+87UYEt5Ku6JrkFhgHdD7w@mail.gmail.com>
In-Reply-To: <xmqqfujnlyru.fsf@gitster.mtv.corp.google.com>

On 9 February 2017 at 23:39, Junio C Hamano <gitster@pobox.com> wrote:

Show 14 quoted lines

> Lars Schneider <larsxschneider@gmail.com> writes:
>
>> unfortunately, I missed to send this v2. I agree with Luke's review and
>> I moved the re-encode of the path name to the `streamOneP4File` and
>> `streamOneP4Deletion` explicitly.
>>
>> Discussion:
>> http://public-inbox.org/git/CAE5ih7-=bD_ZoL5pFYfD2Qvy-XE24V_cgge0XoAvuoTK02EDfg@mail.gmail.com/
>>
>> Thanks,
>> Lars
>
> Thanks.  Will replace but will not immediately merge to 'next' yet,
> just in case Luke wants to tell me add his "Reviewed-by:".

Yes, this looks good to me now.

Luke