git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 4/5] show-ref: Detect dangling refs under --verify as well

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 24, 2017, 02:48 UTC
Message-ID
<xmqqefztp3zd.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170123180059.4288-5-git@thecybershadow.net>
Vladimir Panteleev <git@thecybershadow.net> writes:
Show 21 quoted lines
> Move detection of dangling refs into show_one, so that they are
> detected when --verify is present as well as when it is absent.
>
> Signed-off-by: Vladimir Panteleev <git@thecybershadow.net>
> ---
>  builtin/show-ref.c  | 16 ++++++++--------
>  t/t1403-show-ref.sh | 22 ++++++++++++++++++++++
>  2 files changed, 30 insertions(+), 8 deletions(-)
>
> diff --git a/builtin/show-ref.c b/builtin/show-ref.c
> index ab8e0dc41..107d05fe0 100644
> --- a/builtin/show-ref.c
> +++ b/builtin/show-ref.c
> @@ -22,6 +22,14 @@ static void show_one(const char *refname, const struct object_id *oid)
>  	const char *hex;
>  	struct object_id peeled;
>  
> +	/* This changes the semantics slightly that even under quiet we
> +	 * detect and return error if the repository is corrupt and
> +	 * ref points at a nonexistent object.
> +	 */

This is my fault from more than 10 years ago, but I think the comment shouldn't have been here (or at its original location). It talks about the behaviour change relative to the previous version when the comment was added, i.e. cf0adba788 ("Store peeled refs in packed-refs file.", 2006-11-19).

I'll remove it after the series settles.
Previous: Vladimir PanteleevNext: Junio C Hamano
Message 7 of 8 in “show-ref: Allow -d, --head to work with --verify”
  1. 0/5 show-ref: Allow -d, --head to work with --verifyVladimir Panteleev, Jan 23, 2017
  2. 3/5 show-ref: Move --quiet handling into show_oneVladimir Panteleev, Jan 23, 2017
  3. 5/5 show-ref: Remove dead `if (verify)' checkVladimir Panteleev, Jan 23, 2017
  4. 1/5 show-ref: Accept HEAD with --verifyVladimir Panteleev, Jan 23, 2017
  5. 2/5 show-ref: Allow -d to work with --verifyVladimir Panteleev, Jan 23, 2017
  6. 4/5 show-ref: Detect dangling refs under --verify as wellVladimir Panteleev, Jan 23, 2017
  7. Junio C HamanoJan 24, 2017
  8. Junio C HamanoJan 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.