git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 5/5] show-ref: Remove dead `if (verify)' check

From
Vladimir Panteleev <git@thecybershadow.net>
Date
Jan 23, 2017, 18:00 UTC
Message-ID
<20170123180059.4288-6-git@thecybershadow.net>
In-Reply-To
<20170123180059.4288-1-git@thecybershadow.net>

As show_ref is only ever called on the path where --verify is not specified, `verify' can never possibly be true here.

Signed-off-by: Vladimir Panteleev <git@thecybershadow.net>
---
 builtin/show-ref.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/builtin/show-ref.c b/builtin/show-ref.c
index 107d05fe0..2dfcb5634 100644
--- a/builtin/show-ref.c
+++ b/builtin/show-ref.c
@@ -73,9 +73,6 @@ static int show_ref(const char *refname, const struct object_id *oid,
 				continue;
 			if (len == reflen)
 				goto match;
-			/* "--verify" requires an exact match */
-			if (verify)
-				continue;
 			if (refname[reflen - len - 1] == '/')
 				goto match;
 		}
-- 
2.11.0
Previous: Vladimir PanteleevNext: Vladimir Panteleev
Message 3 of 8 in “show-ref: Allow -d, --head to work with --verify”
  1. 0/5 show-ref: Allow -d, --head to work with --verifyVladimir Panteleev, Jan 23, 2017
  2. 3/5 show-ref: Move --quiet handling into show_oneVladimir Panteleev, Jan 23, 2017
  3. 5/5 show-ref: Remove dead `if (verify)' checkVladimir Panteleev, Jan 23, 2017
  4. 1/5 show-ref: Accept HEAD with --verifyVladimir Panteleev, Jan 23, 2017
  5. 2/5 show-ref: Allow -d to work with --verifyVladimir Panteleev, Jan 23, 2017
  6. 4/5 show-ref: Detect dangling refs under --verify as wellVladimir Panteleev, Jan 23, 2017
  7. Junio C HamanoJan 24, 2017
  8. Junio C HamanoJan 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.