git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] name-rev: Fix tag lookup on repository with mixed types of tags

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 19, 2017, 01:54 UTC
Message-ID
<xmqqefpzkikw.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20171018132420.4577-1-orgads@gmail.com>
orgads@gmail.com writes:
Show 7 quoted lines
> From: Orgad Shaneh <orgads@gmail.com>
>
> Commit 7550424804 (name-rev: include taggerdate in considering the best
> name) introduced a bug in name-rev.
> ...
>  builtin/name-rev.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Can you update a test to protect the change this patch makes from future breakages? That would also demonstrate how the current code is broken and this patch improves the situation, as I am having a bit of trouble seeing why this change is needed.

Thanks.
Previous: orgads@gmail.com
Message 2 of 2 in “name-rev: Fix tag lookup on repository with mixed types of tags”
  1. name-rev: Fix tag lookup on repository with mixed types of tagsorgads@gmail.com, Oct 18, 2017
  2. Junio C HamanoOct 19, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.