From: Junio C Hamano Date: Thu, 19 Oct 2017 01:54:55 GMT Subject: Re: [PATCH] name-rev: Fix tag lookup on repository with mixed types of tags Message-ID: In-Reply-To: <20171018132420.4577-1-orgads@gmail.com> orgads@gmail.com writes: > From: Orgad Shaneh > > Commit 7550424804 (name-rev: include taggerdate in considering the best > name) introduced a bug in name-rev. > ... > builtin/name-rev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Can you update a test to protect the change this patch makes from future breakages? That would also demonstrate how the current code is broken and this patch improves the situation, as I am having a bit of trouble seeing why this change is needed. Thanks.