Re: [PATCH v2 0/2] Accept error packets in any context

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 3, 2019, 23:05 UTC
Message-ID: <xmqqef9tfikg.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181229211915.161686-1-masayasuzuki@google.com>

Masaya Suzuki <masayasuzuki@google.com> writes:

Show 10 quoted lines

> This makes it possible for servers to send an error message back to clients in
> an arbitrary situation.
>
> The first patch was originally sent in [1]. This version includes some fix.
>
> The second patch was originally sent in [2]. Later, this was cherry-picked in
> [3]. In the discussion in [3], we agreed that this error packet handling should
> be done only against the Git pack protocol handling code. With this agreement,
> the patch series sent in [3] is abandoned (according to [4]). This is a patch
> series based on that agreement on limiting the error packet handling.

In short, are you shooting js/smart-http-detect-remote-error topic down and replacing it with this one?

As that topic is not yet in 'next', I am perfectly fine doing that. I just want to make sure that is what you meant, as my reading of [4] was a bit fuzzy.

Thanks.

Show 9 quoted lines

>
> [1]: https://public-inbox.org/git/20181227065210.60817-1-masayasuzuki@google.com/
> [2]: https://public-inbox.org/git/20181127045301.103807-1-masayasuzuki@google.com/
> [3]: https://public-inbox.org/git/df7d3659ae5f11d163f1e992f3b9403be709ddb7.1544572142.git.steadmon@google.com/
> [4]: https://public-inbox.org/git/20181213221826.GE37614@google.com/
>
> Masaya Suzuki (2):
>   Use packet_reader instead of packet_read_line
>   pack-protocol.txt: accept error packets in any context