[PATCH v2 0/2] Accept error packets in any context
- From
Masaya Suzuki <masayasuzuki@google.com>
- Date
- Dec 29, 2018, 21:19 UTC
- Message-ID
- <20181229211915.161686-1-masayasuzuki@google.com>
- In-Reply-To
- <reply-to=20181127045301.103807-1-masayasuzuki@google.com>
This makes it possible for servers to send an error message back to clients in an arbitrary situation.
The first patch was originally sent in [1]. This version includes some fix.
The second patch was originally sent in [2]. Later, this was cherry-picked in [3]. In the discussion in [3], we agreed that this error packet handling should be done only against the Git pack protocol handling code. With this agreement, the patch series sent in [3] is abandoned (according to [4]). This is a patch series based on that agreement on limiting the error packet handling.
[1]: https://public-inbox.org/git/20181227065210.60817-1-masayasuzuki@google.com/ [2]: https://public-inbox.org/git/20181127045301.103807-1-masayasuzuki@google.com/ [3]: https://public-inbox.org/git/df7d3659ae5f11d163f1e992f3b9403be709ddb7.1544572142.git.steadmon@google.com/ [4]: https://public-inbox.org/git/20181213221826.GE37614@google.com/
Masaya Suzuki (2): Use packet_reader instead of packet_read_line pack-protocol.txt: accept error packets in any context
Documentation/technical/pack-protocol.txt | 20 +++---- builtin/archive.c | 19 +++---- builtin/fetch-pack.c | 3 +- builtin/receive-pack.c | 62 +++++++++++---------- builtin/send-pack.c | 3 +- connect.c | 3 -- fetch-pack.c | 65 +++++++++++++---------- pkt-line.c | 4 ++ pkt-line.h | 8 ++- remote-curl.c | 29 ++++++---- send-pack.c | 39 +++++++------- serve.c | 5 +- t/t5703-upload-pack-ref-in-want.sh | 4 +- transport.c | 3 +- upload-pack.c | 40 +++++++------- 15 files changed, 174 insertions(+), 133 deletions(-)
-- 2.20.1.415.g653613c723-goog