Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 8, 2019, 04:18 UTC
Message-ID: <xmqqef6db041.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87h8bb9bmx.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

Show 19 quoted lines

> On Thu, Apr 04 2019, Junio C Hamano wrote:
>
> Just comments on ab/* stuff:
>
>> * ab/gc-reflog (2019-04-01) 7 commits
>>  - gc: handle & check gc.reflogExpire config
>>  - reflog tests: assert lack of early exit with expiry="never"
>>  - reflog tests: test for the "points nowhere" warning
>>  - reflog tests: make use of "test_config" idiom
>>  - gc: refactor a "call me once" pattern
>>  - gc: convert to using the_hash_algo
>>  - gc: remove redundant check for gc_auto_threshold
>>
>>  Fix various glitches in "git gc" around reflog handling.
>>
>>  cf. <20190328161434.19200-1-avarab@gmail.com> (v4)
>
> Missing a "will..." note for this one, the "cf" is just the cover letter
> for v4. AFAICT it should be ready to merge down from "pu".

The former is because I haven't decided and more importantly I haven't seen enough input on the list to make a decision.

The latter is quite normal. cf. is literally "here is one of the things I can look at as a starting point to remind me what this topic was about and what its current state is", a note left for me. It often is "don't forget that somebody raised an issue and I should not merge to to 'next' yet" but it is not limited to objections.

As I haven't seen enough input on the topic, and I have quite a backlog after being offline for a wee, pointing at a cover to make sure I can quickly find out which iteration I happen to have was/is a logical thing to do.

Show 15 quoted lines

>> * ab/gc-docs (2019-04-01) 12 commits
>>  - SQAUSH??? fixup! gc docs: include the "gc.*" section from "config" in "gc"
>>  - gc docs: remove incorrect reference to gc.auto=0
>>  - gc docs: clarify that "gc" doesn't throw away referenced objects
>>  - gc docs: note "gc --aggressive" in "fast-import"
>>  - gc docs: downplay the usefulness of --aggressive
>>  - gc docs: note how --aggressive impacts --window & --depth
>>  - gc docs: fix formatting for "gc.writeCommitGraph"
>>  - gc docs: re-flow the "gc.*" section in "config"
>>  - gc docs: include the "gc.*" section from "config" in "gc"
>>  - gc docs: clean grammar for "gc.bigPackThreshold"
>>  - gc docs: stop noting "repack" flags
>>  - gc docs: modernize the advice for manually running "gc"
>
> That squash makes sense. Will submit another version with it integrated.

OK, then I won't squash it myself, but instead queue the updated patches.

Thanks.