Re: What's cooking in git.git (Apr 2019, #01; Thu, 4)

From: Todd Zullinger <tmz@pobox.com>
Date: Apr 5, 2019, 01:05 UTC
Message-ID: <20190405010556.GN4047@pobox.com>
In-Reply-To: <xmqqr2aidpxw.fsf@gitster-ct.c.googlers.com>

Hi Junio,

Junio C Hamano wrote:

Show 12 quoted lines

> * sg/asciidoctor-in-ci (2019-04-01) 6 commits
>  - ci: fix AsciiDoc/Asciidoctor stderr check in the documentation build job
>  - ci: stick with Asciidoctor v1.5.8 for now
>  - ci: install Asciidoctor in 'ci/install-dependencies.sh'
>  - Documentation/technical/protocol-v2.txt: fix formatting
>  - Documentation/technical/api-config.txt: fix formatting
>  - Documentation/git-diff-tree.txt: fix formatting
> 
>  Update our support to format documentation in the CI environment,
>  either with AsciiDoc ro Asciidoctor.
> 
>  Will merge to 'next'.

Martin mentioned this in reply to the patch thread¹ but it looks like it slipped by unnoticed. There's some extraneous comments in 28216d13f4 ("ci: stick with Asciidoctor v1.5.8 for now", 2019-03-29) which would be good to trim before this hits next.

    commit 28216d13f43b07e41bdd83b786ae31c00c657e06
    Author: SZEDER Gábor <szeder.dev@gmail.com>
    Date:   Fri Mar 29 20:52:46 2019 +0100

        ci: stick with Asciidoctor v1.5.8 for now
        
        On Fri, Mar 29, 2019 at 01:35:19PM +0100, SZEDER Gábor wrote:
        > The release of Asciidoctor v2.0.0 two days ago broke our documentation
        
        Well, what happened "two days ago" when I sent v2 is now seven days
        ago...  Let's just say "recent" instead.
        
          --- >8 ---
        
        Subject: ci: stick with Asciidoctor v1.5.8 for now
        
        The recent release of Asciidoctor v2.0.0 broke our documentation
        ...

¹ <CAN0heSrQrVQ+t3ZH1igU8zZLjjyhzZshFgarLcZOumWMBRN2Tg@mail.gmail.com>

Thanks,

-- 
Todd