git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v8 7/9] blame: add a fingerprint heuristic to match ignored lines

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 13, 2019, 16:38 UTC
Message-ID
<xmqqef3xwid7.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20190613151756.GA31952@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 7 quoted lines
>> +	git blame --ignore-rev $REV_2 --ignore-rev $REV_3 file | sed -e "$pick_author" >actual &&
>
> Please use an intermediate file between 'git blame' and the downstream
> 'sed' command, here and in other tests as well.
>
> This test script focuses specifically on 'git blame', but that pipe
> hides its exit code.

Good point on "this matters even more for 'blame' as the whole point of t8014 _is_ about 'blame' running corretly".

Thanks.
Previous: SZEDER GáborNext: michael@platin.gs
Message 10 of 14 in “blame: add the ability to ignore commits”
  1. 0/9 blame: add the ability to ignore commitsBarret Rhoden, Jun 10, 2019
  2. 1/9 fsck: rename and touch up init_skiplist()Barret Rhoden, Jun 10, 2019
  3. 2/9 Move oidset_parse_file() to oidset.cBarret Rhoden, Jun 10, 2019
  4. 3/9 blame: use a helper function in blame_chunk()Barret Rhoden, Jun 10, 2019
  5. 4/9 blame: add the ability to ignore commits and their changesBarret Rhoden, Jun 10, 2019
  6. 5/9 blame: add config options for the output of ignored or unblamable linesBarret Rhoden, Jun 10, 2019
  7. 6/9 blame: optionally track line fingerprints during fill_blame_origin()Barret Rhoden, Jun 10, 2019
  8. 7/9 blame: add a fingerprint heuristic to match ignored linesBarret Rhoden, Jun 10, 2019
  9. SZEDER GáborJun 13, 2019
  10. Junio C HamanoJun 13, 2019
  11. t8014: avoid git command in upstream pipemichael@platin.gs, Jun 16, 2019
  12. Barret RhodenJun 17, 2019
  13. 8/9 blame: use the fingerprint heuristic to match ignored linesBarret Rhoden, Jun 10, 2019
  14. 9/9 blame: add a test to cover blame_coalesce()Barret Rhoden, Jun 10, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.