From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 13 Jun 2019 16:38:28 GMT
Subject: Re: [PATCH v8 7/9] blame: add a fingerprint heuristic to match ignored lines
Message-ID: <xmqqef3xwid7.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190613151756.GA31952@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

>> +	git blame --ignore-rev $REV_2 --ignore-rev $REV_3 file | sed -e "$pick_author" >actual &&
>
> Please use an intermediate file between 'git blame' and the downstream
> 'sed' command, here and in other tests as well.
>
> This test script focuses specifically on 'git blame', but that pipe
> hides its exit code.

Good point on "this matters even more for 'blame' as the whole point
of t8014 _is_ about 'blame' running corretly".

Thanks.