Re: Propose promoting 'contrib/rerere-train.sh' to command

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 21, 2019, 23:52 UTC
Message-ID: <xmqqeewx6xt6.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20191221193110.GB3339249@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> The situations where I need rerere-train don't come up often, but when
> they do, it has always worked easily and without hiccups for me. So
> perhaps there are lurking gotchas that Junio might know about, but AFAIK
> the quality is high enough for it to be part of normal Git.

I actually suspect that rewriting has a high chance of initially degrading the quality, so we should take a two step approach if we really want it as part of the core distribution. As to the UI, I think "git rerere train a..b" would be a good one, but if the scripted version is of high quality (I haven't looked at it for a long time---even though I used it for a couple of times a year in recent years), perhaps we can add it as "git-rerere--train" subcommand that is spawned from "builtin/rerere.c" for the first cut?

> I'd suggest converting it to C and making it a sub-command of rerere
> (i.e., "git rerere train a..b") rather than a separate command.