git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Propose promoting 'contrib/rerere-train.sh' to command

From
Jeff King <peff@peff.net>
Date
Dec 22, 2019, 07:58 UTC
Message-ID
<20191222075836.GA3425263@coredump.intra.peff.net>
In-Reply-To
<xmqqeewx6xt6.fsf@gitster-ct.c.googlers.com>
On Sat, Dec 21, 2019 at 03:52:53PM -0800, Junio C Hamano wrote:
Show 16 quoted lines
> Jeff King <peff@peff.net> writes:
> 
> > The situations where I need rerere-train don't come up often, but when
> > they do, it has always worked easily and without hiccups for me. So
> > perhaps there are lurking gotchas that Junio might know about, but AFAIK
> > the quality is high enough for it to be part of normal Git.
> 
> I actually suspect that rewriting has a high chance of initially
> degrading the quality, so we should take a two step approach if we
> really want it as part of the core distribution.  As to the UI, I
> think "git rerere train a..b" would be a good one, but if the
> scripted version is of high quality (I haven't looked at it for a
> long time---even though I used it for a couple of times a year in
> recent years), perhaps we can add it as "git-rerere--train"
> subcommand that is spawned from "builtin/rerere.c" for the first
> cut?
Yeah, I'd be pretty happy with that, too.

I just suspect its ultimate fate is conversion to C, given the general trend. And converting it to C that just calls out to other git commands via run_command would presumably behave just like the original, leaving the more challenging and error-prone conversion for later. Hopefully any upgrade to "real Git command" would include some tests, though. :)

-Peff
Previous: Junio C HamanoNext: Tom Miller
Message 6 of 8 in “Propose promoting 'contrib/rerere-train.sh' to command”
  1. Tom MillerDec 21, 2019
  2. Philip OakleyDec 21, 2019
  3. Philip OakleyDec 21, 2019
  4. Jeff KingDec 21, 2019
  5. Junio C HamanoDec 21, 2019
  6. Jeff KingDec 22, 2019
  7. Tom MillerDec 22, 2019
  8. Johannes SchindelinJan 1, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.