Re: [PATCH v9] credential-store: warn instead of fatal for bogus lines from store
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 1, 2020, 05:27 UTC
- Message-ID
- <xmqqees4p6mb.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CAPUEspiD10bYsCDoHM6PJdidyofNadJL0bexjiNNZCXNU+Ay_Q@mail.gmail.com>
Carlo Arenas <carenas@gmail.com> writes:
Show 5 quoted lines
> PS. should we really do the warn even in store/erase operations as a > followup or is the warning not useful as is, and probably then all > operations should be quiet (as Jonathan suggested originally?) and we > could do warn (and maybe fix) in a different change (maybe adding a > fsck command of sorts)?
Yeah, I think I like the "no warning, just ignore" much better. The implementation I suspect would become a lot simpler, right?
Thanks for thinking one extra step.