Re: [PATCH v10] credential-store: ignore bogus lines from store file
- From
Carlo Marcelo Arenas Belón <carenas@gmail.com>
- Date
- May 2, 2020, 21:05 UTC
- Message-ID
- <20200502210553.GA41113@Carlos-MBP>
- In-Reply-To
- <20200502181643.38203-1-carenas@gmail.com>
Dscho,
this was tested[1] in windows and was able to reproduce the bogus issues with credential store in macOS using t0302.50
[1] https://github.com/carenas/git/actions/runs/93858709
Junio,
will followup with a more comprehensive fix for the problems with '\r' which will obiously need also changes in credential.c, but that IMHO might be more of a prerequisite for the next iteration (the one that warns)
would be very helpful if you squash the following, otherwise
Carlo -- >8 -- Subject: [PATCH] SQUASH!!!
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> --- t/t0302-credential-store.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t0302-credential-store.sh b/t/t0302-credential-store.sh index 9fd0aca55e..a05b64c8b3 100755 --- a/t/t0302-credential-store.sh +++ b/t/t0302-credential-store.sh @@ -120,7 +120,7 @@ test_expect_success 'erase: erase matching credentials from both xdg and home fi ' invalid_credential_test() { - test_expect_success 'get: ignore credentials without $1 as invalid' ' + test_expect_success "get: ignore credentials without $1 as invalid" ' echo "$2" >"$HOME/.git-credentials" && check fill store <<-\EOF protocol=https
-- 2.26.2.686.gfaf46a9ccd