Re: post-checkout hook aborts rebase

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 12, 2020, 00:51 UTC
Message-ID: <xmqqeen7n7f6.fsf@gitster.c.googlers.com>
In-Reply-To: <99BE0DDB-C248-4781-A715-2517A977372B@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 9 quoted lines

> On a slightly related note, I noticed that that part of the documentation is not 100% exact. I states:
> "Further, both backends only call the post-checkout hook with the starting point commit of the rebase, 
> not the intermediate commits nor the final commit."
>
> but I noticed that in an interactive rebase, the post-checkout hook *is* called for commits
> marked as "edit", when the rebase stops to edit them (I haven't checked if it's called when the rebase stops
> for other reasons, like conflicts.)
>
> Maybe we should tweak the wording of the doc  ?

Yeah, we should do either that, or fix the code and make it not to call the post-checkout hook so aggressively, as suggested during the discussion.

Thanks.