Re: post-checkout hook aborts rebase

From: Chris Torek <chris.torek@gmail.com>
Date: Aug 27, 2020, 20:32 UTC
Message-ID: <CAPx1GvdQKw-4yjNMfqZtDQUBg3-dGbkPpV+0FyjJx-a3bQaQ-Q@mail.gmail.com>
In-Reply-To: <CABPp-BEEmqdt2_OuNQFxyf6pkppBWptkcvuAYhWX8r+_Wr8-2g@mail.gmail.com>

> On Thu, Aug 27, 2020 at 12:07 PM Chris Torek <chris.torek@gmail.com> wrote:
> > The *last* checkout from the finished rebase perhaps *should* [invoke

a hook]

On Thu, Aug 27, 2020 at 1:11 PM Elijah Newren <newren@gmail.com> wrote:

> What do you mean by the "last checkout"?  I believe a typical
> non-interactive rebase of N patches has only one checkout, and I don't
> see why running hooks for the starting point is relevant.

I meant for the final state after rewriting the commits -- but that's actually the post-rewrite hook, not the post-checkout hook. I had them conflated mentally when I wrote the above.

Show 5 quoted lines

> If hooks are wanted for rebase, I'd still want to have rebase-specific
> ones, because most people who think of "checkout hooks" or "commit
> hooks" probably aren't going to think of them the way rebase or
> cherry-pick happen to use them.  (And that might even be more true for
> --interactive and --rebase-merges cases.)

I agree with this.

Chris