Re: [PATCH 5/6] reflog: free() ref given to us by dwim_log()

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 22, 2021, 00:16 UTC
Message-ID: <xmqqee8dgbhq.fsf@gitster.g>
In-Reply-To: <patch-5.6-85b7b7aef37-20211021T155529Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 17 quoted lines

> When dwim_log() returns the "ref" is always ether NULL or an
> xstrdup()'d string.
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  builtin/reflog.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/builtin/reflog.c b/builtin/reflog.c
> index bd4c669918d..175c83e7cc2 100644
> --- a/builtin/reflog.c
> +++ b/builtin/reflog.c
> @@ -653,6 +653,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix)
>  					should_expire_reflog_ent,
>  					reflog_expiry_cleanup,
>  					&cb);
> +		free(ref);

OK. When dwim_log() returns false, it would not have touched &ref at all, so the "continue" (not shown in the context above) is not leaking, and this loop looks good.

Thanks.

>  	}
>  	return status;
>  }