[PATCH 6/6] repack: stop leaking a "struct child_process"

From

Ævar Arnfjörð Bjarmason <avarab@gmail.com>

Date

Oct 21, 2021, 15:57 UTC

Message-ID

<patch-6.6-526d5649156-20211021T155529Z-avarab@gmail.com>

In-Reply-To

<cover-0.6-00000000000-20211021T155529Z-avarab@gmail.com>

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/repack.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/builtin/repack.c b/builtin/repack.c
index 0b2d1e5d82b..50730517c7b 100644
--- a/builtin/repack.c
+++ b/builtin/repack.c
@@ -258,9 +258,11 @@ static void repack_promisor_objects(const struct pack_objects_args *args,
 	for_each_packed_object(write_oid, &cmd,
 			       FOR_EACH_OBJECT_PROMISOR_ONLY);
 
-	if (cmd.in == -1)
+	if (cmd.in == -1) {
+		child_process_clear(&cmd);
 		/* No packed objects; cmd was never started */
 		return;
+	}
 
 	close(cmd.in);
 

-- 
2.33.1.1494.g88b39a443e1