Re: [PATCH v2] fuzz: add basic fuzz testing for git command

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2022, 17:37 UTC
Message-ID: <xmqqedwbi5kw.fsf@gitster.g>
In-Reply-To: <pull.1351.v2.git.1663349383852.gitgitgadget@gmail.com>

"Arthur Chan via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> From: Arthur Chan <arthur.chan@adalogics.com>
>
> fuzz-cmd-base.c / fuzz-cmd-base.h provides base functions for
> fuzzing on git command which are compatible with libFuzzer
> (and possibly other fuzzing engines).
> fuzz-cmd-status.c provides first git command fuzzing target
> as a demonstration of the approach.

As I said in my review on the previous round, please make the "cleaning up of existing stuff" and "addition of new stuff" into two separate patches, the latter building on top of the former. That will make it easier to review the former (as there shouldn't be anything that would add or change the way how the moved stuff interacts with the rest of the world) and also the latter (as the scope of the second patch would be much smaller and more focused).

Thanks.