Re: [PATCH v2] fuzz: add basic fuzz testing for git command
- From
Arthur Chan <arthur.chan@adalogics.com>
- Date
- Sep 16, 2022, 18:07 UTC
- Message-ID
- <81aa1467-9771-6ada-06ec-824dcdafdf68@adalogics.com>
- In-Reply-To
- <xmqqedwbi5kw.fsf@gitster.g>
On 16/9/2022 6:37 pm, Junio C Hamano wrote:
Show 18 quoted lines
> "Arthur Chan via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> From: Arthur Chan <arthur.chan@adalogics.com> >> >> fuzz-cmd-base.c / fuzz-cmd-base.h provides base functions for >> fuzzing on git command which are compatible with libFuzzer >> (and possibly other fuzzing engines). >> fuzz-cmd-status.c provides first git command fuzzing target >> as a demonstration of the approach. > As I said in my review on the previous round, please make the > "cleaning up of existing stuff" and "addition of new stuff" into two > separate patches, the latter building on top of the former. That > will make it easier to review the former (as there shouldn't be > anything that would add or change the way how the moved stuff > interacts with the rest of the world) and also the latter (as the > scope of the second patch would be much smaller and more focused). > > Thanks.
Thanks. Sorry for the misunderstanding on my side. I will go ahead and create a PR for moving of fuzzing before submitting another on for new fuzzers. Thanks very much for your kind suggestions and time.
Cheers.
ADA Logics Ltd is registered in England. No: 11624074. Registered office: 266 Banbury Road, Post Box 292, OX2 7DL, Oxford, Oxfordshire , United Kingdom