Re: [PATCH] submodule: Accept -v for update command

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 18, 2022, 01:25 UTC
Message-ID: <xmqqedsxzen6.fsf@gitster.g>
In-Reply-To: <f805f2da-a7e1-9fde-cc0a-04a30f79c9af@cs-ware.de>

Sven Strickroth <email@cs-ware.de> writes:

Show 9 quoted lines

> Subject: Re: [PATCH] submodule: Accept -v for update command
>
> "git pull -v --recurse-submodules" propagates the "-v" to the
> submodule command which did not support "-v" yet.
>
> Commit a56771a668d introduced this regression.
>
> Signed-off-by: Sven Strickroth <email@cs-ware.de>
> ---

This unfortunately fell in the cracks. Thanks for a few people who reported the issue this patch tried to fix recently (it is curous why this regression that is almost 5 years old suddenly started biting people).

Applying the improvement suggestions given in the review messages to the other patch to deal with this regression from the "pull" side, let's explain the commit this way:

    Subject: [PATCH] submodule: accept -v for the update command

    Since a56771a6 (builtin/pull: respect verbosity settings in
    submodules, 2018-01-25), "git pull -v --recurse-submodules"
    propagates the "-v" to the submodule command, but because the
    latter command does not understand the option, it barfs.

    Teach "git submodule update" to accept the option to fix it.

    Signed-off-by: Sven Strickroth <email@cs-ware.de>
    
Thanks.

Show 17 quoted lines

>  git-submodule.sh | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 9a50f2e912..7f9582d923 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -244,6 +244,9 @@ cmd_update()
>  		-q|--quiet)
>  			quiet=1
>  			;;
> +		-v|--verbose)
> +			quiet=0
> +			;;
>  		--progress)
>  			progress=1
>  			;;