Re: [PATCH] Don't pass -v to submodule command

From: Sven Strickroth <email@cs-ware.de>
Date: Dec 1, 2022, 08:32 UTC
Message-ID: <80d5eb7c-c668-d325-2aaa-cbee742d1f15@cs-ware.de>
In-Reply-To: <221130.868rjsi6bn.gmgdl@evledraar.gmail.com>

Am 30.11.2022 um 20:17 schrieb Ævar Arnfjörð Bjarmason:

Show 17 quoted lines

>> --- a/builtin/pull.c
>> +++ b/builtin/pull.c
>> @@ -256,7 +256,7 @@ static struct option pull_options[] = {
>>   /**
>>    * Pushes "-q" or "-v" switches into arr to match the opt_verbosity level.
>>    */
>> -static void argv_push_verbosity(struct strvec *arr)
>> +static void argv_push_verbosity(struct strvec *arr, int include_v)
>>   {
>>   	int verbosity;
>>
> 
> It looks like you're getting somewhere with this, but you never use this
> "include_v", so the bug is still there. We just have the scaffolding
> now.
> 
> Did you forget to add that part to this commit?

Opps, seems so.

> In any case, that serves as a comment on the other thing this patch
> really needs: tests, please add some.

I don't know how to add tests and don't have a fully fledged build environment for git here.

-- 
Best regards,
   Sven Strickroth
   PGP key id F5A9D4C4 @ any key-server