git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] diff-lib: honor override_submodule_config flag bit

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 14, 2023, 07:06 UTC
Message-ID
<xmqqedmezfn9.fsf@gitster.g>
In-Reply-To
<20230614041626.2979067-2-sokcevic@google.com>
Josip Sokcevic <sokcevic@google.com> writes:
> When `diff.ignoreSubmodules = all` is set and a submodule commit is
> manually staged, `git-commit` should accept it.

What does "it" refer to in this sentence? Does "accept"ing mean "Even if the configuration tells us to ignore all submodules, the command should record the commit with updated submodule"? Or does it mean "as the configuration tells us to ignore all submodules, the command should honor that wish and the command should record the commit with the same commit at the submodule path as the parent commit, ignoring the manual addition"? The sentence needs to be rewritten to clarify so that readers won't have to ask the above question.

Everything else I wrote in my draft review I notice was adequately covered by Eric's review, so I've removed them from this message.

Thanks.
Previous: Eric SunshineNext: Josip Sokcevic
Message 3 of 4 in “diff-lib: honor override_submodule_config flag bit”
  1. diff-lib: honor override_submodule_config flag bitJosip Sokcevic, Jun 14, 2023
  2. Eric SunshineJun 14, 2023
  3. Junio C HamanoJun 14, 2023
  4. Josip SokcevicJun 14, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.