From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 14 Jun 2023 07:06:50 GMT
Subject: Re: [PATCH] diff-lib: honor override_submodule_config flag bit
Message-ID: <xmqqedmezfn9.fsf@gitster.g>
In-Reply-To: <20230614041626.2979067-2-sokcevic@google.com>

Josip Sokcevic <sokcevic@google.com> writes:

> When `diff.ignoreSubmodules = all` is set and a submodule commit is
> manually staged, `git-commit` should accept it.

What does "it" refer to in this sentence?  Does "accept"ing mean
"Even if the configuration tells us to ignore all submodules, the
command should record the commit with updated submodule"?  Or does
it mean "as the configuration tells us to ignore all submodules, the
command should honor that wish and the command should record the
commit with the same commit at the submodule path as the parent
commit, ignoring the manual addition"?  The sentence needs to be
rewritten to clarify so that readers won't have to ask the above
question.

Everything else I wrote in my draft review I notice was adequately
covered by Eric's review, so I've removed them from this message.

Thanks.