Re: [PATCH v3] sequencer: rectify empty hint in call of require_clean_work_tree()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2023, 16:04 UTC
- Message-ID
- <xmqqedkahoio.fsf@gitster.g>
- In-Reply-To
- <ZNTI6xpXIRaoFlxx@ugly>
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> it becomes actually relevant only after my "rebase: improve resumption > from incorrect initial todo list" patch, which still needs reworking.
We are already past -rc1 by the time you see this response, so this fix is not of immediate urgency. It has been with us for more than several cycles, it does not seem to be readily triggerable, and its effect is merely a single extra empty error message when other things are mentioned there.
Even if it may not be triggerable, consistent use of the API is something that is worth aiming for.
If I were working on a separate change (i.e. your "resume from bad initial todo") that will make this triggerable, I would explain this patch as a pure clean-up patch to use the API function consistently, and tell readers that there is currently no way to trigger it (assuming that it is the case---I only poked a bit yesterday and would not claim that I did a thorough investigation), and that it will start mattering with a later step in the series. And make it an early part of the series that will contain the "resume from bad initial todo" patch.
Thanks.