Re: [PATCH v3] sequencer: rectify empty hint in call of require_clean_work_tree()

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 9, 2023, 21:44 UTC
Message-ID: <xmqq7cq3lwli.fsf@gitster.g>
In-Reply-To: <20230809171531.2564829-1-oswald.buddenhagen@gmx.de>

Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:

> The canonical way to represent "no error hint" is making it NULL, which
> shortcuts the error() call altogether. This fixes the output by removing
> the line which said just "error:", which would appear when starting a
> rebase whose initial checkout worked fine despite a dirty worktree. This

Thanks for adding this info.

"git rebase" does not seem to start (i.e. does not perform "initial checkout") from a dirty working tree, with

	error: cannot rebase: You have unstaged changes.
	error: Please commit or stash them.

at least from my quick attempt. I am not sure if this is actually triggerble?

In any case, I've replaced v2 that I had with this version, as the description is much better. The change to the code does look correct but now it does not seem to trigger, it is unclear to me if the fix is merely theoretical (a command-by-command transcript would have helped here).

Thanks.