Re: [PATCH] sideband.c: replace int with size_t for clarity
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 22, 2023, 19:01 UTC
- Message-ID
- <xmqqedfejc32.fsf@gitster.g>
- In-Reply-To
- <20231222175747.GA2880@tb-raspi4>
Torsten Bögershausen <tboegi@web.de> writes:
Just this part.
Show 11 quoted lines
> Further down, we read
> for (i = 0; i < ARRAY_SIZE(keywords); i++) {
>
> However, a size of an array can never be negative, so that
> an unsigned data type is a better choice than a signed.
> And, arrays can have more elements than an int can address,
> at least in theory.
> For a reader it makes more sense, to replace
> int i;
> with
> size_t i;It is a very good discipline to use size_t to index into an array whose size is externally controled (e.g., we slurp what the end user or the server on the other end of the connection gave us into a piece of memory we allocate) to avoid integer overflows as "int" is often narrower than "size_t". But this particular one is a Meh; the keywords[] is a small hardcoded array whose size and contents are totally under our control.