Re: [PATCH 02/12] name-hash: add index_dir_exists2()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 20, 2024, 19:34 UTC
Message-ID: <xmqqedd7nd4u.fsf@gitster.g>
In-Reply-To: <1913ed1b-a145-e641-6601-d8a55a2a8fec@jeffhostetler.com>

Jeff Hostetler <git@jeffhostetler.com> writes:

> I'm always a little hesitant to change the signature of an existing
> function and chasing all of the callers in the middle of another
> task.  It can sometimes be distracting to reviewers.

Of course we all should be hesitant. In addition to reviewers, there are topics in flight and topics people are cooking but not posted that will be affected. So it is perfectly fine to introduce an enhanced version as needed under different name (but let's not give it a meaningless name like "foo2" where it is totally unclear and unexplained what its difference from "foo" is from the name), but if it is meant as an enhanced version, we should aim to share the code and rewrite the original in terms of the enhanced one, instead of simply duplicating to risk unnecessary divergence of the two functions in the future.

Thanks.