Re: [PATCH v3 00/14] FSMonitor edge cases on case-insensitive file systems

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 6, 2024, 12:58 UTC
Message-ID: <ZehofMaSZyUq8S1N@tanuki>
In-Reply-To: <pull.1662.v3.git.1708983565.gitgitgadget@gmail.com>

On Mon, Feb 26, 2024 at 09:39:11PM +0000, Jeff Hostetler via GitGitGadget wrote:

Show 13 quoted lines

> Here is version 3. I think I have addressed the remaining comments.
> 
> I cleaned up the test code to use the test_expect_failure at the beginning
> and squashed in the test_expect_success version of tests into the final
> commit in the series.
> 
> I moved the invalidate_ce_fsm() commit earlier in the series, so that the
> final commit actually uses all of the up-to-this-point changes to fix the
> problem.
> 
> I converted a few "should not happens" to BUG()s.
> 
> Thanks to everyone for their time and attention reviewing this. Jeff

I gave this whole patch series a read and didn't much to complain about. There are a couple of nits, but none of them really require a reroll in my opinion.

Thanks!

Patrick