git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] cache-tree: detect mismatching number of index entries

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 24, 2024, 17:01 UTC
Message-ID
<xmqqed59ugsy.fsf@gitster.g>
In-Reply-To
<ZvJgnqSwANCXmj0G@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 9 quoted lines
>> I guess as long as "it" is not folded, it does not matter how other
>> paths from different directories in active_cache[] are sparsified or
>> expanded, as long as "pos" keeps track of the current position
>> correctly.
>
> It seems like we end up calling `ensure_full_index()` for a sparse
> index, which does cause us to signal to the caller that they should
> restart verification. So for all I understand, this function shouldn't
> act on a sparsely-populated index.
OK.  That sounds sensible and safe.
Previous: Patrick SteinhardtNext: Patrick Steinhardt
Message 8 of 13 in “cache-tree: fix segfaults with invalid cache-trees”
  1. 0/3 cache-tree: fix segfaults with invalid cache-treesPatrick Steinhardt, Sep 17, 2024
  2. 1/3 cache-tree: refactor verification to return error codesPatrick Steinhardt, Sep 17, 2024
  3. Eric SunshineSep 17, 2024
  4. Patrick SteinhardtSep 18, 2024
  5. 2/3 cache-tree: detect mismatching number of index entriesPatrick Steinhardt, Sep 17, 2024
  6. Junio C HamanoSep 19, 2024
  7. Patrick SteinhardtSep 24, 2024
  8. Junio C HamanoSep 24, 2024
  9. 3/3 unpack-trees: detect mismatching number of cache-tree/index entriesPatrick Steinhardt, Sep 17, 2024
  10. 0/3 cache-tree: fix segfaults with invalid cache-treesPatrick Steinhardt, Oct 7, 2024
  11. 1/3 cache-tree: refactor verification to return error codesPatrick Steinhardt, Oct 7, 2024
  12. 2/3 cache-tree: detect mismatching number of index entriesPatrick Steinhardt, Oct 7, 2024
  13. 3/3 unpack-trees: detect mismatching number of cache-tree/index entriesPatrick Steinhardt, Oct 7, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.