From: Junio C Hamano Date: Tue, 24 Sep 2024 17:01:33 GMT Subject: Re: [PATCH 2/3] cache-tree: detect mismatching number of index entries Message-ID: In-Reply-To: Patrick Steinhardt writes: >> I guess as long as "it" is not folded, it does not matter how other >> paths from different directories in active_cache[] are sparsified or >> expanded, as long as "pos" keeps track of the current position >> correctly. > > It seems like we end up calling `ensure_full_index()` for a sparse > index, which does cause us to signal to the caller that they should > restart verification. So for all I understand, this function shouldn't > act on a sparsely-populated index. OK. That sounds sensible and safe.