git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v9 2/4] branch: let delete_branches() name where a branch landed

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 20, 2026, 19:32 UTC
Message-ID
<xmqqeccfpacc.fsf@gitster.g>
In-Reply-To
<c4513f9ec1315c34b7a75b95bf50bba59043c274.1795184664.git.gitgitgadget@gmail.com>
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 24 quoted lines
> @@ -357,15 +359,33 @@ static int delete_branches(int argc, const char **argv, int kinds,
>  	for_each_string_list_item(item, &refs_to_delete) {
>  		char *describe_ref = item->util;
>  		char *name = item->string;
> +		struct commit *landed = landed_commits ?
> +			strmap_get(landed_commits, name + branch_name_pos) : NULL;
> +		const char *landed_abbrev = landed ?
> +			repo_find_unique_abbrev(the_repository,
> +						&landed->object.oid,
> +						DEFAULT_ABBREV) : NULL;
> +
>  		if (flags & DELETE_BRANCH_DRY_RUN) {
> -			if (!(flags & DELETE_BRANCH_QUIET))
> +			if (flags & DELETE_BRANCH_QUIET)
> +				;
> +			else if (landed)
> +				printf(_("Would delete branch %s (was %s, landed as %s).\n"),
> +				       name + branch_name_pos, describe_ref,
> +				       landed_abbrev);
> +			else
>  				printf(remote_branch
>  					? _("Would delete remote-tracking branch %s (was %s).\n")
>  					: _("Would delete branch %s (was %s).\n"),
>  					name + branch_name_pos, describe_ref);

The use of an empty "if" statement body is a clean way to express that nothing will be emitted under "--quiet" without making the code too deeply nested. Nicely done.

This is not a new issue, but this makes me wonder if giving the "--dry-run" and the "--quiet" options together makes sense. Would users really gain much information from "--quiet" when they are so paranoid as to want a preview of what would happen with "--dry-run"?

Show 12 quoted lines
>  		} else if (!refs_ref_exists(get_main_ref_store(the_repository), name)) {
>  			char *refname = name + branch_name_pos;
> -			if (!(flags & DELETE_BRANCH_QUIET))
> +			if (flags & DELETE_BRANCH_QUIET)
> +				;
> +			else if (landed)
> +				printf(_("Deleted branch %s (was %s, landed as %s).\n"),
> +				       refname, describe_ref, landed_abbrev);
> +			else
>  				printf(remote_branch
>  					? _("Deleted remote-tracking branch %s (was %s).\n")
>  					: _("Deleted branch %s (was %s).\n"),
Likewise.

I wonder if it makes the code structure cleaner to follow if we swap the order of checks between "are we doing dry-run" (which is on the outside in the current code structure) and "what is the reason we remove this branch" (which is the inner if/elseif cascade) by having these different message templates (currently a pair of three-message sets) in an array and choosing which set to use based on "--dry-run". There are of course a few things that are done only in the non-dry-run mode (like removing the branch configuration and the branch itself). In other words, a code structure like this

	const char *msg_templates[2][3] = {
		{ "Would delete branch %s ...", ..., ..., },
		{ "Deleted branch %s ...", ..., ..., },
	};
	const char *use_msg[3] = msg_templates[!dry_run];
	for-each-branch-to-be-deleted {
		compute if branch has landed;
		if (quiet)
			;
		else if (landed)
			printf(_(use_msg[0]), ...);
		else if (remote_branch)
			printf(_(use_msg[1]), ...);
		else
			printf(_(use_msg[2]), ...);
		if (!dry_run)
			remove branch and its configuration;
		else
			what is only done in dry-run mode (if exists)
	}
		
may make it easier to follow for readers?
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren via GitGitGadget
Message 99 of 104 in “branch: let --delete-merged find squash merged branches”
  1. branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Sep 29, 2026
  2. Kristoffer HaugsbakkSep 29, 2026
  3. Harald NordgrenSep 29, 2026
  4. Kristoffer HaugsbakkSep 29, 2026
  5. D. Ben KnobleSep 29, 2026
  6. Kristoffer HaugsbakkSep 29, 2026
  7. D. Ben KnobleSep 29, 2026
  8. Harald NordgrenSep 29, 2026
  9. Harald NordgrenSep 29, 2026
  10. D. Ben KnobleSep 29, 2026
  11. Harald NordgrenSep 29, 2026
  12. Phillip WoodOct 4, 2026
  13. Harald NordgrenOct 4, 2026
  14. Phillip WoodOct 8, 2026
  15. Harald NordgrenOct 8, 2026
  16. Kristoffer HaugsbakkOct 9, 2026
  17. Harald NordgrenOct 9, 2026
  18. Harald NordgrenOct 9, 2026
  19. Phillip WoodOct 9, 2026
  20. Phillip WoodOct 9, 2026
  21. Harald NordgrenOct 9, 2026
  22. D. Ben KnobleOct 8, 2026
  23. Phillip WoodOct 9, 2026
  24. 0/2 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Oct 11, 2026
  25. 1/2 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Oct 11, 2026
  26. 2/2 branch: add --no-squashed to skip the squash searchHarald Nordgren via GitGitGadget, Oct 11, 2026
  27. Junio C HamanoOct 12, 2026
  28. Phillip WoodOct 12, 2026
  29. Harald NordgrenOct 12, 2026
  30. Junio C HamanoOct 12, 2026
  31. Harald NordgrenOct 12, 2026
  32. Junio C HamanoOct 13, 2026
  33. Harald NordgrenOct 17, 2026
  34. Jasper MayoneOct 19, 2026
  35. Harald NordgrenOct 18, 2026
  36. Harald NordgrenOct 12, 2026
  37. D. Ben KnobleOct 12, 2026
  38. 0/3 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Oct 21, 2026
  39. 1/3 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Oct 21, 2026
  40. 2/3 branch: let --delete-merged find rebase merged branchesHarald Nordgren via GitGitGadget, Oct 21, 2026
  41. 3/3 branch: add --squashed to find squash merged branchesHarald Nordgren via GitGitGadget, Oct 21, 2026
  42. Jasper MayoneOct 21, 2026
  43. Harald NordgrenOct 21, 2026
  44. D. Ben KnobleOct 22, 2026
  45. Harald NordgrenOct 22, 2026
  46. Junio C HamanoOct 22, 2026
  47. Harald NordgrenOct 22, 2026
  48. Junio C HamanoOct 22, 2026
  49. Junio C HamanoOct 22, 2026
  50. Harald NordgrenOct 22, 2026
  51. Jasper MayoneOct 22, 2026
  52. Junio C HamanoOct 22, 2026
  53. Harald NordgrenOct 23, 2026
  54. Harald NordgrenOct 22, 2026
  55. D. Ben KnobleOct 22, 2026
  56. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Oct 26, 2026
  57. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Oct 26, 2026
  58. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Oct 26, 2026
  59. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Oct 26, 2026
  60. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Oct 26, 2026
  61. Jasper MayoneOct 29, 2026
  62. Harald NordgrenOct 29, 2026
  63. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Oct 30, 2026
  64. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Oct 30, 2026
  65. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Oct 30, 2026
  66. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Oct 30, 2026
  67. Junio C HamanoOct 30, 2026
  68. Harald NordgrenOct 31, 2026
  69. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Oct 30, 2026
  70. Junio C HamanoOct 30, 2026
  71. Harald NordgrenOct 31, 2026
  72. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Nov 1, 2026
  73. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Nov 1, 2026
  74. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Nov 1, 2026
  75. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Nov 1, 2026
  76. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Nov 1, 2026
  77. Harald NordgrenNov 11, 2026
  78. Jasper MayoneNov 11, 2026
  79. Harald NordgrenNov 14, 2026
  80. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Nov 14, 2026
  81. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Nov 14, 2026
  82. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Nov 14, 2026
  83. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Nov 14, 2026
  84. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Nov 14, 2026
  85. Tuomas AholaNov 14, 2026
  86. Jasper MayoneNov 16, 2026
  87. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Nov 17, 2026
  88. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Nov 17, 2026
  89. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Nov 17, 2026
  90. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Nov 17, 2026
  91. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Nov 17, 2026
  92. Junio C HamanoNov 18, 2026
  93. Jasper MayoneNov 19, 2026
  94. 0/4 branch: let --delete-merged find squash merged branchesHarald Nordgren via GitGitGadget, Nov 20, 2026
  95. 1/4 branch: move the deleteMerged opt-out check into a helperHarald Nordgren via GitGitGadget, Nov 20, 2026
  96. Junio C HamanoNov 20, 2026
  97. Junio C HamanoNov 20, 2026
  98. 2/4 branch: let delete_branches() name where a branch landedHarald Nordgren via GitGitGadget, Nov 20, 2026
  99. Junio C HamanoNov 20, 2026
  100. 3/4 branch: add --delete-integrated to delete rebase and squash merged branchesHarald Nordgren via GitGitGadget, Nov 20, 2026
  101. Junio C HamanoNov 20, 2026
  102. 4/4 branch: let --delete-integrated find branches merged onto changed filesHarald Nordgren via GitGitGadget, Nov 20, 2026
  103. Junio C HamanoNov 20, 2026
  104. Junio C HamanoNov 20, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.