Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 11, 2013, 18:11 UTC
Message-ID: <xmqqd2oftehr.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAHGBnuOFYS-9+h0H3VD5X-EbZKX9nENaZfAZbLUm9zwDtr-3SA@mail.gmail.com>

Sebastian Schuberth <sschuberth@gmail.com> writes:

Show 23 quoted lines

> On Wed, Sep 11, 2013 at 6:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> Karsten Blees <karsten.blees@gmail.com> writes:
>>
>>> A few minor fixes for the MSVC build.
>>>
>>> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>>>
>>> Karsten Blees (3):
>>>   MSVC: fix compile errors due to missing libintl.h
>>>   MSVC: fix compile errors due to macro redefinitions
>>>   MSVC: fix stat definition hell
>>>
>>>  compat/mingw.h   | 21 +++++++++++++++++----
>>>  compat/msvc.h    | 15 ---------------
>>>  config.mak.uname |  1 +
>>>  3 files changed, 18 insertions(+), 19 deletions(-)
>>
>> I won't be a good person to review, suggest improvements on, and/or
>> judge these patches.  I'm Cc'ing regulars who work on mingw port for
>> their help and Ack.
>
> Acked-by: Sebastian Schuberth <sschuberth@gmail.com>

Thanks; will queue these three and your follow-up on top.