git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Fix MSVC compile errors and cleanup stat definitions

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Sep 11, 2013, 16:16 UTC
Message-ID
<CAHGBnuOFYS-9+h0H3VD5X-EbZKX9nENaZfAZbLUm9zwDtr-3SA@mail.gmail.com>
In-Reply-To
<xmqqa9jjuypf.fsf@gitster.dls.corp.google.com>
On Wed, Sep 11, 2013 at 6:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Karsten Blees <karsten.blees@gmail.com> writes:
>
>> A few minor fixes for the MSVC build.
>>
>> Also here: https://github.com/kblees/git/tree/kb/fix-msvc-stat-definitions
>>
>> Karsten Blees (3):
>>   MSVC: fix compile errors due to missing libintl.h
>>   MSVC: fix compile errors due to macro redefinitions
>>   MSVC: fix stat definition hell
>>
>>  compat/mingw.h   | 21 +++++++++++++++++----
>>  compat/msvc.h    | 15 ---------------
>>  config.mak.uname |  1 +
>>  3 files changed, 18 insertions(+), 19 deletions(-)
>
> I won't be a good person to review, suggest improvements on, and/or
> judge these patches.  I'm Cc'ing regulars who work on mingw port for
> their help and Ack.
Acked-by: Sebastian Schuberth <sschuberth@gmail.com>
-- 
Sebastian Schuberth
Previous: Junio C HamanoNext: Junio C Hamano
Message 8 of 9 in “Fix MSVC compile errors and cleanup stat definitions”
  1. 0/3 Fix MSVC compile errors and cleanup stat definitionsKarsten Blees, Sep 10, 2013
  2. 1/3 MSVC: fix compile errors due to missing libintl.hKarsten Blees, Sep 10, 2013
  3. 2/3 MSVC: fix compile errors due to macro redefinitionsKarsten Blees, Sep 10, 2013
  4. 3/3 MSVC: fix stat definition hellKarsten Blees, Sep 10, 2013
  5. Eric SunshineSep 11, 2013
  6. Sebastian SchuberthSep 11, 2013
  7. Junio C HamanoSep 11, 2013
  8. Sebastian SchuberthSep 11, 2013
  9. Junio C HamanoSep 11, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.