Re: [PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 25, 2013, 22:42 UTC
- Message-ID
- <xmqqd2low1b5.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <xmqqtxf0w440.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Perhaps a preparatory patch needs to rename the structure type to > object_name_list or something. And then we can make the variable > names, not typenames, responsible for signalling what they mean, > i.e. > > get_remote_heads(... > struct list_of_objects *extra_have, > struct list_of_objects *shallow_points); > > when we introduce the new parameter.
Yuck, and these are not "list-of-objects", either. They are "list-of-object-names".