Re: [PATCH v3 06/28] connect.c: teach get_remote_heads to parse "shallow" lines

From: Duy Nguyen <pclouds@gmail.com>
Date: Nov 27, 2013, 13:02 UTC
Message-ID: <CACsJy8CwbNuOVuQ7nBjXuosX-5MCo_u1pFUHqLXzBa9hd7M8Vg@mail.gmail.com>
In-Reply-To: <xmqqd2low1b5.fsf@gitster.dls.corp.google.com>

On Tue, Nov 26, 2013 at 5:42 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
>> Perhaps a preparatory patch needs to rename the structure type to
>> object_name_list or something.  And then we can make the variable
>> names, not typenames, responsible for signalling what they mean,
>> i.e.
>>
>>       get_remote_heads(...
>>               struct list_of_objects *extra_have,
>>                 struct list_of_objects *shallow_points);
>>
>> when we introduce the new parameter.
>
> Yuck, and these are not "list-of-objects", either.  They are
> "list-of-object-names".

I was thinking of renaming it to sha1_array and what do you know, we do have 'struct sha1_array' with exact same (or better) functionality that extra_have_objects provides. Will replace extra_have_objects with current sha1_array.

-- 
Duy