Re: [RFC v2] submodule: Respect requested branch on all clones

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 7, 2014, 18:27 UTC
Message-ID: <xmqqd2k3ejfr.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CALas-ijNgaTQr77DZw3acypgaJHpDFVnGdq97ECM4zu+CPma0w@mail.gmail.com>

Francesco Pretto <ceztko@gmail.com> writes:

Show 14 quoted lines

> 2014/1/7 Francesco Pretto <ceztko@gmail.com>:
>> To not break the existing behavior what it's really needed here, IMO,
>> is a "submodule.<name>.attached" property that says two things:
>> - at the first clone on "git submodule update" stay attached to
>> "submodule.<name>.branch";
>> - implies "--remote", as it's the only thing that makes sense when the
>> submodules are attached.
>>
>
> Unless you decide to go with the proposed approach of Trevor, where
> "submodule.<name>.branch" set means attached (if it's not changed:
> this thread is quite hard to follow...). To this end, Junio could sync
> with more "long-timers" (Heiko?) submodule users/devs to understand if
> this breaks too much or not.

It is not immediately obvious to me why anybody who specifies the submodule.*.branch variable to say "I want _that_ branch" not to want to be on that branch but in a detached state, so from that perspective, submodule.*.attach feels superfluous.

But I'd mostly defer the design discussion to Heiko (and Jens), WTK and you.