Re: Re: [RFC v2] submodule: Respect requested branch on all clones
- From
Francesco Pretto <ceztko@gmail.com>
- Date
- Jan 15, 2014, 00:02 UTC
- Message-ID
- <CALas-ihMfpQHr4nt9WO_att-2FDLvRYzxr-UVhfEsmRzLWafJg@mail.gmail.com>
- In-Reply-To
- <20140114224246.GA13271@book.hvoigt.net>
2014/1/14 Heiko Voigt <hvoigt@hvoigt.net>:
Show 16 quoted lines
> On Tue, Jan 14, 2014 at 02:22:31PM -0800, W. Trevor King wrote: >> On Tue, Jan 14, 2014 at 10:46:08PM +0100, Heiko Voigt wrote: >> > I would like to step back a bit and get back to the original problem >> > at hand: Francescos original use case of an attached head for direct >> > commits on a stable branch in a submodule. How about we finish >> > discussing the exact solution of that first. AFAIK that is already >> > solved with the following: >> > >> > * Trevor's first patch[2] to create a branch on initial clone of a submodule > [...] > >> > That should be all (and IIRC Francesco agreed) needed for that use-case. >> >> That was my understanding [3] ;). > >
I've been silent these days but yes: I confirm Trevor's second patch iteration[1] gives, IMO, a better meaning of the submodule.<name>.branch property and is perfectly fine for my use case, to the point of stopping pursuing for my non behavior changing patch[4] (I still think it deserved some more in depth reviews, though ;) ).
Cheers, Francesco
[1]: http://article.gmane.org/gmane.comp.version-control.git/239967 [2]: http://article.gmane.org/gmane.comp.version-control.git/239973 [3]: http://article.gmane.org/gmane.comp.version-control.git/240139 [4]: http://article.gmane.org/gmane.comp.version-control.git/239956