Re: [PATCH 0/5] diff_filespec cleanups and optimizations

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 17, 2014, 18:49 UTC
Message-ID: <xmqqd2jqxx2x.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140117011844.GA6870@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 9 quoted lines

> But while looking at it, I noticed a bunch of cleanups for
> diff_filespec.  With the patches below, sizeof(struct diff_filespec) on
> my 64-bit machine goes from 96 bytes down to 80. Compiling with "-m32"
> goes from 64 bytes down to 52.
>
> The first few patches have cleanup value aside from the struct size
> improvement. The last two are pure optimization. I doubt the
> optimization is noticeable for any real-life cases, so I don't mind if
> they get dropped. But they're quite trivial and obvious.

Thanks for a pleasant read.