git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/5] diff_filespec: drop funcname_pattern_ident field

From
Jeff King <peff@peff.net>
Date
Jan 17, 2014, 01:20 UTC
Message-ID
<20140117012011.GB7249@sigill.intra.peff.net>
In-Reply-To
<20140117011844.GA6870@sigill.intra.peff.net>

This struct field was obsoleted by be58e70 (diff: unify external diff and funcname parsing code, 2008-10-05), but we forgot to remove it.

Signed-off-by: Jeff King <peff@peff.net>
---
8 bytes of our size savings come here...
 diffcore.h | 1 -
 1 file changed, 1 deletion(-)
diff --git a/diffcore.h b/diffcore.h
index f822f9e..92e4d48 100644
--- a/diffcore.h
+++ b/diffcore.h
@@ -29,7 +29,6 @@ struct diff_filespec {
 	char *path;
 	void *data;
 	void *cnt_data;
-	const char *funcname_pattern_ident;
 	unsigned long size;
 	int count;               /* Reference count */
 	int xfrm_flags;		 /* for use by the xfrm */
-- 
1.8.5.2.500.g8060133
Previous: Junio C HamanoNext: Jeff King
Message 6 of 10 in “diff_filespec cleanups and optimizations”
  1. 0/5 diff_filespec cleanups and optimizationsJeff King, Jan 17, 2014
  2. 1/5 diff_filespec: reorder dirty_submodule macro definitionsJeff King, Jan 17, 2014
  3. Junio C HamanoJan 17, 2014
  4. Jeff KingJan 17, 2014
  5. Junio C HamanoJan 17, 2014
  6. 2/5 diff_filespec: drop funcname_pattern_ident fieldJeff King, Jan 17, 2014
  7. 3/5 diff_filespec: drop xfrm_flags fieldJeff King, Jan 17, 2014
  8. 4/5 diff_filespec: reorder is_binary fieldJeff King, Jan 17, 2014
  9. 5/5 diff_filespec: use only 2 bits for is_binary flagJeff King, Jan 17, 2014
  10. Junio C HamanoJan 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.