Re: [PATCH 4/8] submodule-config: introduce parse_generic_submodule_config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 3, 2016, 23:09 UTC
- Message-ID
- <xmqqd1sdl7bx.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <1454435497-26429-5-git-send-email-sbeller@google.com>
Stefan Beller <sbeller@google.com> writes:
> This rewrites parse_config to distinguish between configs specific to > one submodule and configs which apply generically to all submodules. > We do not have generic submodule configs yet, but the next patch will > introduce "submodule.fetchJobs".
OK.
Show 12 quoted lines
> +static int parse_config(const char *var, const char *value, void *data)
> +{
> + struct parse_config_parameter *me = data;
> + int subsection_len;
> + const char *subsection, *key;
> +
> + if (parse_config_key(var, "submodule", &subsection,
> + &subsection_len, &key) < 0)
> + return 0;
> +
> + if (!subsection_len)
> + return parse_generic_submodule_config(key, var, value, me);The same comment as in the footnote for the review on [3/8] applies here.
Show 9 quoted lines
> + else
> + return parse_specific_submodule_config(subsection,
> + subsection_len, key,
> + var, value, me);
> +}
> +
> static int gitmodule_sha1_from_commit(const unsigned char *commit_sha1,
> unsigned char *gitmodules_sha1)
> {