git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/8] submodule-config: introduce parse_generic_submodule_config

From
Stefan Beller <sbeller@google.com>
Date
Feb 3, 2016, 23:26 UTC
Message-ID
<CAGZ79kZwGPNHeZFcu7-60U8cTZhC8t6TZ5=4ZzBbP+4MrLqRZQ@mail.gmail.com>
In-Reply-To
<xmqqd1sdl7bx.fsf@gitster.mtv.corp.google.com>
On Wed, Feb 3, 2016 at 3:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> This rewrites parse_config to distinguish between configs specific to
>> one submodule and configs which apply generically to all submodules.
>> We do not have generic submodule configs yet, but the next patch will
>> introduce "submodule.fetchJobs".
>
> OK.
>
>> +static int parse_config(const char *var, const char *value, void *data)
>> +{
>> +     struct parse_config_parameter *me = data;
>> +     int subsection_len;
>> +     const char *subsection, *key;
>> +
>> +     if (parse_config_key(var, "submodule", &subsection,
>> +                          &subsection_len, &key) < 0)
>> +             return 0;
>> +
>> +     if (!subsection_len)
>> +             return parse_generic_submodule_config(key, var, value, me);
>
> The same comment as in the footnote for the review on [3/8] applies
> here.
Ok, so we want to have
    [section ""]
and
    [section]

be different, such that we could have a submodule with an "" name, but still be able to differentiate to the common section which should be applied to all submodules?

It sounds like a corner case to me, but if we want to guarantee such a behavior, let me see if test cases for that need some special love in this series.

Thanks, Stefan

Previous: Junio C HamanoNext: Junio C Hamano
Message 11 of 22 in “[PATCHv7 0/8] Expose submodule parallelism to the user”
  1. Stefan BellerFeb 2, 2016
  2. 1/8 submodule-config: keep update strategy aroundStefan Beller, Feb 2, 2016
  3. Junio C HamanoFeb 3, 2016
  4. Jeff KingFeb 4, 2016
  5. 2/8 submodule-config: drop check against NULLStefan Beller, Feb 2, 2016
  6. Junio C HamanoFeb 3, 2016
  7. 3/8 submodule-config: remove name_and_item_from_varStefan Beller, Feb 2, 2016
  8. Junio C HamanoFeb 3, 2016
  9. 4/8 submodule-config: introduce parse_generic_submodule_configStefan Beller, Feb 2, 2016
  10. Junio C HamanoFeb 3, 2016
  11. Stefan BellerFeb 3, 2016
  12. Junio C HamanoFeb 4, 2016
  13. 5/8 fetching submodules: respect `submodule.fetchJobs` config optionStefan Beller, Feb 2, 2016
  14. Junio C HamanoFeb 3, 2016
  15. 6/8 git submodule update: have a dedicated helper for cloningStefan Beller, Feb 2, 2016
  16. Junio C HamanoFeb 3, 2016
  17. Stefan BellerFeb 3, 2016
  18. Junio C HamanoFeb 4, 2016
  19. Stefan BellerFeb 4, 2016
  20. Junio C HamanoFeb 4, 2016
  21. 7/8 submodule update: expose parallelism to the userStefan Beller, Feb 2, 2016
  22. 8/8 clone: allow an explicit argument for parallel submodule clonesStefan Beller, Feb 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.