git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] compat: add qsort_s()

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 1, 2016, 23:37 UTC
Message-ID
<xmqqd1hb6x0t.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<955e9bf4-d1cd-f01a-13f1-7a335dea011a@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 10 quoted lines
>> You can hack around it by passing a wrapper callback that flips the
>> arguments. Since we have a "void *" data pointer, that would point to a
>> struct holding the "real" callback and chaining to the original data
>> pointer.
>>
>> It does incur the cost of an extra level of indirection for each
>> comparison, though (not just for each qsort call).
>
> Indeed.  We'd need a perf test to measure that overhead before we
> could determine if that's a problem, though.
I agree.  Hopefully it won't be too much cost.
Show 7 quoted lines
>> You could do it as zero-cost if you were willing to turn the comparison
>> function definition into a macro.
>
> Ugh.  That either requires changing the signature of qsort_s() based
> on the underlying native function as well, or using a void pointer to
> pass the comparison function, no?  Let's not do that, at least not
> without a good reason.

Let's not go there. It may be zero runtime cost, but the cognitive cost for people who need to code the comparison callback using the macro is high.

Previous: René ScharfeNext: Junio C Hamano
Message 9 of 16 in “string-list: make string_list_sort() reentrant”
  1. 0/3 string-list: make string_list_sort() reentrantRené Scharfe, Dec 1, 2016
  2. 1/3 compat: add qsort_s()René Scharfe, Dec 1, 2016
  3. René ScharfeDec 1, 2016
  4. Jeff KingDec 1, 2016
  5. Junio C HamanoDec 1, 2016
  6. Jeff KingDec 1, 2016
  7. Junio C HamanoDec 1, 2016
  8. René ScharfeDec 1, 2016
  9. Junio C HamanoDec 1, 2016
  10. Junio C HamanoDec 1, 2016
  11. Jeff KingDec 1, 2016
  12. René ScharfeDec 12, 2016
  13. Jeff KingDec 12, 2016
  14. René ScharfeDec 21, 2016
  15. 2/3 add QSORT_SRené Scharfe, Dec 1, 2016
  16. 3/3 string-list: use QSORT_S in string_list_sort()René Scharfe, Dec 1, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.