[PATCH 2/3] add QSORT_S
- From
René Scharfe <l.s.r@web.de>
- Date
- Dec 1, 2016, 16:28 UTC
- Message-ID
- <d7e9bf45-98ca-4245-7740-ef71f71610aa@web.de>
- In-Reply-To
- <3083fbf7-d67e-77e4-e05f-94a7e7e15eba@web.de>
Add the macro QSORT_S, a convenient wrapper for qsort_s() that infers the size of the array elements and dies on error.
Basically all possible errors are programming mistakes (passing NULL as base of a non-empty array, passing NULL as comparison function, out-of-bounds accesses), so terminating the program should be acceptable for most callers.
Signed-off-by: Rene Scharfe <l.s.r@web.de> --- git-compat-util.h | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/git-compat-util.h b/git-compat-util.h index d25f0bd4c..b707dd880 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -994,6 +994,11 @@ int git_qsort_s(void *base, size_t nmemb, size_t size, #define qsort_s git_qsort_s #endif +#define QSORT_S(base, n, compar, ctx) do { \ + if (qsort_s((base), (n), sizeof(*(base)), compar, ctx)) \ + die("BUG: qsort_s() failed"); \ +} while (0) + #ifndef REG_STARTEND #error "Git requires REG_STARTEND support. Compile with NO_REGEX=NeedsStartEnd" #endif
-- 2.11.0