git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] wt-status.c: improve readability for wt_shortstatus_print

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 17, 2017, 05:25 UTC
Message-ID
<xmqqd1dga30a.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20170316225108.GB9135@aiede.mtv.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 10 quoted lines
> Stefan Beller wrote:
>
>> Subject: wt-status.c: improve readability for wt_shortstatus_print
>
> Maybe:
>
> 	wt-status: simplify by using for_each_string_list_item
>
> 	Improve readability by using the for_each_string_list_item helper
> 	instead of manually iterating with an integer counter.

Much better. That matches what I read from the patch when I skimmed it, but it did leave me wondering if I missed something else.

Show 6 quoted lines
>> Signed-off-by: Stefan Beller <sbeller@google.com>
>> ---
>>  wt-status.c | 20 +++++---------------
>>  1 file changed, 5 insertions(+), 15 deletions(-)
>
> I like the diffstat. :)
Me too ;-)
>
> With or without a clarified commit message,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Previous: Jonathan Nieder
Message 3 of 3 in “wt-status.c: improve readability for wt_shortstatus_print”
  1. wt-status.c: improve readability for wt_shortstatus_printStefan Beller, Mar 16, 2017
  2. Jonathan NiederMar 16, 2017
  3. Junio C HamanoMar 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.